Lint Analysis Results Report for UsingDLLDlg.cpp

Summary

Implementation file:	D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\samples\GettingStarted\UsingDLL\UsingDLLDlg.cpp
Project:	UsingDLL
Solution:	usingdll.dsw [configuration: Win32 Debug]
Analysis Status:	Complete
Last Analysed:	Monday, January 05, 2009, 14:29:32
Analysis Time:	00 hours 00 minutes 04 seconds
Total Issues:	31
Elective Notes:	11 (35.48%)
Informational:	14 (45.16%)
Warnings:	6 (19.35%)
Errors:	0 (0.00%)
Internal Errors:	0 (0.00%)
Fatal Errors:	0 (0.00%)
User:	Anna
Computer:	GABRIELLE

Charts

Issue count by category Issue count by message number

Detailed Analysis Results

Order	Category	Severity	Issue No.	Source File	Line No.	Issue Text
1	Elective Note	1	1931	UsingDLLDlg.h	20	Constructor 'CUsingDLLDlg::CUsingDLLDlg(CWnd *)' can be used for implicit conversions -- More Effective C++ #5
2	Elective Note	1	1925	UsingDLLDlg.h	25	Symbol 'CUsingDLLDlg::m_HyperLink' is a public data member -- Effective C++ #20 & Eff. C++ 3rd Ed. item 22
3	Information	2	1768	UsingDLLDlg.h	40	Virtual function 'CUsingDLLDlg::OnInitDialog(void)' has an access (protected) different from the access (public) in the base class (CDialog)
4	Elective Note	1	1926	UsingDLLDlg.cpp	64	Symbol 'CUsingDLLDlg::m_HyperLink's default constructor implicitly called -- Effective C++ #12
5	Elective Note	1	1927	UsingDLLDlg.cpp	64	Symbol 'CUsingDLLDlg::m_hIcon' did not appear in the constructor initializer list -- Effective C++ #12
6	Warning	3	534	UsingDLLDlg.cpp	104	Ignoring return value of function 'ATL::CStringT<char,StrTraitMFC_DLL<char>>::LoadStringA(unsigned int)' (compare with line 1968, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\cstringt.h)
7	Information	2	830	C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\cstringt.h	1968	Location cited in prior message
8	Warning	3	534	UsingDLLDlg.cpp	107	Ignoring return value of function 'CMenu::AppendMenuA(unsigned int, unsigned int, const char *)' (compare with line 979, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h)
9	Information	2	830	C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h	979	Location cited in prior message
10	Warning	3	534	UsingDLLDlg.cpp	108	Ignoring return value of function 'CMenu::AppendMenuA(unsigned int, unsigned int, const char *)' (compare with line 979, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h)
11	Information	2	830	C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h	979	Location cited in prior message
12	Elective Note	1	953	UsingDLLDlg.cpp	120	Variable 'pSysMenu' (line 100) could be declared as const --- Eff. C++ 3rd Ed. item 3
13	Information	2	830	UsingDLLDlg.cpp	100	Location cited in prior message
14	Warning	3	534	UsingDLLDlg.cpp	127	Ignoring return value of function 'CDialog::DoModal(void)' (compare with line 2797, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h)
15	Information	2	830	C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h	2797	Location cited in prior message
16	Elective Note	1	1924	UsingDLLDlg.cpp	145	C-style cast -- More Effective C++ #2
17	Warning	3	534	UsingDLLDlg.cpp	145	Ignoring return value of function 'CWnd::SendMessageA(unsigned int, unsigned int, long)' (compare with line 2037, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h)
18	Information	2	830	C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h	2037	Location cited in prior message
19	Information	2	834	UsingDLLDlg.cpp	152	Operator '-' followed by operator '+' is confusing. Use parentheses.
20	Information	2	834	UsingDLLDlg.cpp	153	Operator '-' followed by operator '+' is confusing. Use parentheses.
21	Warning	3	534	UsingDLLDlg.cpp	156	Ignoring return value of function 'CDC::DrawIcon(int, int, struct HICON__ *)' (compare with line 647, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h)
22	Information	2	830	C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h	647	Location cited in prior message
23	Elective Note	1	953	UsingDLLDlg.cpp	157	Variable 'cxIcon' (line 148) could be declared as const --- Eff. C++ 3rd Ed. item 3
24	Information	2	830	UsingDLLDlg.cpp	148	Location cited in prior message
25	Elective Note	1	953	UsingDLLDlg.cpp	157	Variable 'cyIcon' (line 149) could be declared as const --- Eff. C++ 3rd Ed. item 3
26	Information	2	830	UsingDLLDlg.cpp	149	Location cited in prior message
27	Elective Note	1	953	UsingDLLDlg.cpp	157	Variable 'x' (line 152) could be declared as const --- Eff. C++ 3rd Ed. item 3
28	Information	2	830	UsingDLLDlg.cpp	152	Location cited in prior message
29	Elective Note	1	953	UsingDLLDlg.cpp	157	Variable 'y' (line 153) could be declared as const --- Eff. C++ 3rd Ed. item 3
30	Information	2	830	UsingDLLDlg.cpp	153	Location cited in prior message
31	Elective Note	1	1924	UsingDLLDlg.cpp	168	C-style cast -- More Effective C++ #2

Raw Analysis Results

--- Module:   UsingDLLDlg.cpp (C++)
 WINVER not defined. Defaulting to 0x0501 (Windows XP and Windows .NET Server) 
Automatically linking with UTD.lib - please make sure this file is built. 
    CUsingDLLDlg(CWnd* pParent = NULL);    // standard constructor
UsingDLLDlg.h(20): error 1931: (Note -- Constructor 'CUsingDLLDlg::CUsingDLLDlg(CWnd *)' can be used for implicit conversions -- More Effective C++ #5)
    COXStaticHyperLink    m_HyperLink;
UsingDLLDlg.h(25): error 1925: (Note -- Symbol 'CUsingDLLDlg::m_HyperLink' is a public data member -- Effective C++ #20 & Eff. C++ 3rd Ed. item 22)
    virtual BOOL OnInitDialog();
UsingDLLDlg.h(40): error 1768: (Info -- Virtual function 'CUsingDLLDlg::OnInitDialog(void)' has an access (protected) different from the access (public) in the base class (CDialog))
{
UsingDLLDlg.cpp(64): error 1926: (Note -- Symbol 'CUsingDLLDlg::m_HyperLink's default constructor implicitly called -- Effective C++ #12)
UsingDLLDlg.cpp(64): error 1927: (Note -- Symbol 'CUsingDLLDlg::m_hIcon' did not appear in the constructor initializer list -- Effective C++ #12)
        strAboutMenu.LoadString(IDS_ABOUTBOX);
UsingDLLDlg.cpp(104): error 534: (Warning -- Ignoring return value of function 'ATL::CStringT<char,StrTraitMFC_DLL<char>>::LoadStringA(unsigned int)' (compare with line 1968, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\cstringt.h))
C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\cstringt.h(1968): error 830: (Info -- Location cited in prior message)
            pSysMenu->AppendMenu(MF_SEPARATOR);
UsingDLLDlg.cpp(107): error 534: (Warning -- Ignoring return value of function 'CMenu::AppendMenuA(unsigned int, unsigned int, const char *)' (compare with line 979, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h(979): error 830: (Info -- Location cited in prior message)
            pSysMenu->AppendMenu(MF_STRING, IDM_ABOUTBOX, strAboutMenu);
UsingDLLDlg.cpp(108): error 534: (Warning -- Ignoring return value of function 'CMenu::AppendMenuA(unsigned int, unsigned int, const char *)' (compare with line 979, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h(979): error 830: (Info -- Location cited in prior message)
}
UsingDLLDlg.cpp(120): error 953: (Note -- Variable 'pSysMenu' (line 100) could be declared as const --- Eff. C++ 3rd Ed. item 3)
UsingDLLDlg.cpp(100): error 830: (Info -- Location cited in prior message)
        dlgAbout.DoModal();
UsingDLLDlg.cpp(127): error 534: (Warning -- Ignoring return value of function 'CDialog::DoModal(void)' (compare with line 2797, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h(2797): error 830: (Info -- Location cited in prior message)
        SendMessage(WM_ICONERASEBKGND, (WPARAM) dc.GetSafeHdc(), 0);
UsingDLLDlg.cpp(145): error 1924: (Note -- C-style cast -- More Effective C++ #2)
UsingDLLDlg.cpp(145): error 534: (Warning -- Ignoring return value of function 'CWnd::SendMessageA(unsigned int, unsigned int, long)' (compare with line 2037, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h(2037): error 830: (Info -- Location cited in prior message)
        int x = (rect.Width() - cxIcon + 1) / 2;
UsingDLLDlg.cpp(152): error 834: (Info -- Operator '-' followed by operator '+' is confusing.  Use parentheses.)
        int y = (rect.Height() - cyIcon + 1) / 2;
UsingDLLDlg.cpp(153): error 834: (Info -- Operator '-' followed by operator '+' is confusing.  Use parentheses.)
        dc.DrawIcon(x, y, m_hIcon);
UsingDLLDlg.cpp(156): error 534: (Warning -- Ignoring return value of function 'CDC::DrawIcon(int, int, struct HICON__ *)' (compare with line 647, file C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\atlmfc\include\afxwin.h(647): error 830: (Info -- Location cited in prior message)
    }
UsingDLLDlg.cpp(157): error 953: (Note -- Variable 'cxIcon' (line 148) could be declared as const --- Eff. C++ 3rd Ed. item 3)
UsingDLLDlg.cpp(148): error 830: (Info -- Location cited in prior message)
    }
UsingDLLDlg.cpp(157): error 953: (Note -- Variable 'cyIcon' (line 149) could be declared as const --- Eff. C++ 3rd Ed. item 3)
UsingDLLDlg.cpp(149): error 830: (Info -- Location cited in prior message)
    }
UsingDLLDlg.cpp(157): error 953: (Note -- Variable 'x' (line 152) could be declared as const --- Eff. C++ 3rd Ed. item 3)
UsingDLLDlg.cpp(152): error 830: (Info -- Location cited in prior message)
    }
UsingDLLDlg.cpp(157): error 953: (Note -- Variable 'y' (line 153) could be declared as const --- Eff. C++ 3rd Ed. item 3)
UsingDLLDlg.cpp(153): error 830: (Info -- Location cited in prior message)
    return (HCURSOR) m_hIcon;
UsingDLLDlg.cpp(168): error 1924: (Note -- C-style cast -- More Effective C++ #2)

--- Global Wrap-up

 error 900: (Note -- Successful completion, 31 messages produced)