Issue count by category  Issue count by message number  |
Lint Analysis Results Report for OXAdvancedAssertMail.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Complete |
| Last Analysed: | 08 October 2008, 11:55:55 |
| Total Issues: | 33 |
| Elective Notes: | 7 (21.21%) |
| Informational: | 21 (63.64%) |
| Warnings: | 5 (15.15%) |
| Errors: | 0 (0.00%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category Issue count by message number |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Warning | 3 | 1551 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 53 | Function may throw exception '...' in destructor 'COXAdvancedAssertMail::~COXAdvancedAssertMail(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8 |
| 2 | Warning | 3 | 1551 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 55 | Function may throw exception '...' in destructor 'COXAdvancedAssertMail::~COXAdvancedAssertMail(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8 |
| 3 | Information | 2 | 1740 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 57 | pointer member 'COXAdvancedAssertMail::m_hInstMail' (line 55, file ..\..\Include\OXAdvancedAssertMail.h) not directly freed or zeroed by destructor -- Effective C++ #6 |
| 4 | Information | 2 | 830 | ..\..\Include\OXAdvancedAssertMail.h | 55 | Location cited in prior message |
| 5 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 89 | Ignoring return value of function 'FreeLibrary(struct HINSTANCE__ *)' (compare with line 2583, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
| 6 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 2583 | Location cited in prior message |
| 7 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 101 | Ignoring return value of function 'COXAdvancedAssertMail::LoadMapiLibrary(void)' (compare with line 66) |
| 8 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 66 | Location cited in prior message |
| 9 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 103 | do ... while(0); |
| 10 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 107 | do ... while(0); |
| 11 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 122 | do ... while(0); |
| 12 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 126 | do ... while(0); |
| 13 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 139 | Variable 'ulStatus' (line 136) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 14 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 136 | Location cited in prior message |
| 15 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 149 | do ... while(0); |
| 16 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 153 | do ... while(0); |
| 17 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 163 | Loss of sign (return) (long to unsigned long) |
| 18 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 253 | Loss of precision (initialization) (unsigned long to int) |
| 19 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 267 | Ignoring return value of function 'CWnd::SetActiveWindow(void)' (compare with line 2365, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 20 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2365 | Location cited in prior message |
| 21 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 319 | Variable 'ulParentWnd' (line 239) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 22 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 239 | Location cited in prior message |
| 23 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 319 | Variable 'nError' (line 253) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 24 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 253 | Location cited in prior message |
| 25 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 319 | Variable 'pwndParent' (line 238) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 26 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 238 | Location cited in prior message |
| 27 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 327 | Parameter 'pszSubject' (line 324) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 28 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 324 | Location cited in prior message |
| 29 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 327 | Parameter 'pszAttachment' (line 324) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 30 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 324 | Location cited in prior message |
| 31 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 327 | Parameter 'pszBody' (line 324) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 32 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 324 | Location cited in prior message |
| 33 | Information | 2 | 766 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp | 342 | Header file '..\..\Include\UTB64Bit.h' not used in module 'D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp' |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp (C++)
if ( IsLoaded() )
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(53): error 1551: (Warning -- Function may throw exception '...' in destructor 'COXAdvancedAssertMail::~COXAdvancedAssertMail(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8)
FreeMapiLibrary() ;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(55): error 1551: (Warning -- Function may throw exception '...' in destructor 'COXAdvancedAssertMail::~COXAdvancedAssertMail(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(57): error 1740: (Info -- pointer member 'COXAdvancedAssertMail::m_hInstMail' (line 55, file ..\..\Include\OXAdvancedAssertMail.h) not directly freed or zeroed by destructor -- Effective C++ #6)
..\..\Include\OXAdvancedAssertMail.h(55): error 830: (Info -- Location cited in prior message)
::FreeLibrary ( m_hInstMail ) ;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(89): error 534: (Warning -- Ignoring return value of function 'FreeLibrary(struct HINSTANCE__ *)' (compare with line 2583, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(2583): error 830: (Info -- Location cited in prior message)
LoadMapiLibrary() ;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(101): error 534: (Warning -- Ignoring return value of function 'COXAdvancedAssertMail::LoadMapiLibrary(void)' (compare with line 66))
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(66): error 830: (Info -- Location cited in prior message)
#... eak() ; } while (0) /*lint -restore */
ASSERT( IsLoaded() ); // Careful, we might already be inside an assert.
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(103): error 717: (Info -- do ... while(0);)
#... E__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT( m_lpfnMAPILogon != NULL ); // Careful, we might already be inside an assert.
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(107): error 717: (Info -- do ... while(0);)
#... eak() ; } while (0) /*lint -restore */
ASSERT( IsLoaded() ); // Careful, we might already be inside an assert.
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(122): error 717: (Info -- do ... while(0);)
#... NE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT( m_lpfnMAPILogoff != NULL ); // Careful, we might already be inside an assert.
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(126): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(139): error 953: (Note -- Variable 'ulStatus' (line 136) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(136): error 830: (Info -- Location cited in prior message)
#... eak() ; } while (0) /*lint -restore */
ASSERT( IsLoaded() ); // Careful, we might already be inside an assert.
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(149): error 717: (Info -- do ... while(0);)
#... LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT( m_lpfnMAPISendMail != NULL ); // Careful, we might already be inside an assert.
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(153): error 717: (Info -- do ... while(0);)
return m_lpfnMAPISendMail ( m_lhSession, PtrToUlong(ulUIParam), lpMessage, flFlags, ulReserved ) ;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(163): error 732: (Info -- Loss of sign (return) (long to unsigned long))
int nError = appMailState->SendMail ( PtrToUlong(ulParentWnd), &message, MAPI_LOGON_UI | MAPI_DIALOG, 0 ) ;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(253): error 713: (Info -- Loss of precision (initialization) (unsigned long to int))
pwndParent->SetActiveWindow() ;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(267): error 534: (Warning -- Ignoring return value of function 'CWnd::SetActiveWindow(void)' (compare with line 2365, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2365): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(319): error 953: (Note -- Variable 'ulParentWnd' (line 239) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(239): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(319): error 953: (Note -- Variable 'nError' (line 253) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(253): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(319): error 953: (Note -- Variable 'pwndParent' (line 238) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(238): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(327): error 952: (Note -- Parameter 'pszSubject' (line 324) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(324): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(327): error 952: (Note -- Parameter 'pszAttachment' (line 324) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(324): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(327): error 952: (Note -- Parameter 'pszBody' (line 324) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(324): error 830: (Info -- Location cited in prior message)
--- Wrap-up for Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp(342): error 766: (Info -- Header file '..\..\Include\UTB64Bit.h' not used in module 'D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXAdvancedAssertMail.cpp')
--- Global Wrap-up
error 900: (Note -- Successful completion, 33 messages produced)