Lint Analysis Results Report for OXBMPFilePickerCombo.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Complete |
| Last Analysed: | 08 October 2008, 11:57:06 |
| Total Issues: | 15 |
| Elective Notes: | 6 (40.00%) |
| Informational: | 7 (46.67%) |
| Warnings: | 2 (13.33%) |
| Errors: | 0 (0.00%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category ![]() Issue count by message number ![]() |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 20 | Symbol 'COXHistoryCombo' did not appear in the constructor initializer list -- Effective C++ #12 |
| 2 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 21 | parameter 'sFileExtFilter' in function 'COXBMPFilePickerCombo::COXBMPFilePickerCombo(ATL::CStringT<char,StrTraitMFC_DLL<char>>)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
| 3 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 21 | Parameter 'sFileExtFilter' (line 18) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 4 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 18 | Location cited in prior message |
| 5 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 24 | Symbol 'COXHistoryCombo' did not appear in the constructor initializer list -- Effective C++ #12 |
| 6 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 24 | Symbol 'COXBMPFilePickerCombo::m_sFileExtFilter's default constructor implicitly called -- Effective C++ #12 |
| 7 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 25 | Loss of sign (arg. no. 1) (int to unsigned int) |
| 8 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 25 | Ignoring return value of function 'ATL::CStringT<char,StrTraitMFC_DLL<char>>::LoadStringA(unsigned int)' (compare with line 1988, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\cstringt.h) |
| 9 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\cstringt.h | 1988 | Location cited in prior message |
| 10 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 62 | Ignoring return value of function 'CWnd::SendMessageA(unsigned int, unsigned int, long) const' (compare with line 2222, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 11 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2222 | Location cited in prior message |
| 12 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 66 | Variable 'pParentWnd' (line 57) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 13 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 57 | Location cited in prior message |
| 14 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 66 | Pointer variable 'pParentWnd' (line 57) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 15 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp | 57 | Location cited in prior message |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp (C++)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(20): error 1928: (Note -- Symbol 'COXHistoryCombo' did not appear in the constructor initializer list -- Effective C++ #12)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(21): error 1746: (Info -- parameter 'sFileExtFilter' in function 'COXBMPFilePickerCombo::COXBMPFilePickerCombo(ATL::CStringT<char,StrTraitMFC_DLL<char>>)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(21): error 952: (Note -- Parameter 'sFileExtFilter' (line 18) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(18): error 830: (Info -- Location cited in prior message)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(24): error 1928: (Note -- Symbol 'COXHistoryCombo' did not appear in the constructor initializer list -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(24): error 1926: (Note -- Symbol 'COXBMPFilePickerCombo::m_sFileExtFilter's default constructor implicitly called -- Effective C++ #12)
m_sFileExtFilter.LoadString(nID);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(25): error 732: (Info -- Loss of sign (arg. no. 1) (int to unsigned int))
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(25): error 534: (Warning -- Ignoring return value of function 'ATL::CStringT<char,StrTraitMFC_DLL<char>>::LoadStringA(unsigned int)' (compare with line 1988, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\cstringt.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\cstringt.h(1988): error 830: (Info -- Location cited in prior message)
(LPARAM)GetSafeHwnd());
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(62): error 534: (Warning -- Ignoring return value of function 'CWnd::SendMessageA(unsigned int, unsigned int, long) const' (compare with line 2222, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2222): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(66): error 953: (Note -- Variable 'pParentWnd' (line 57) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(57): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(66): error 954: (Note -- Pointer variable 'pParentWnd' (line 57) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXBMPFilePickerCombo.cpp(57): error 830: (Info -- Location cited in prior message)
--- Global Wrap-up
error 900: (Note -- Successful completion, 15 messages produced)