Issue count by category  Issue count by message number  |
Lint Analysis Results Report for OXColorPickerButton.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Complete |
| Last Analysed: | 08 October 2008, 11:58:42 |
| Total Issues: | 65 |
| Elective Notes: | 21 (32.31%) |
| Informational: | 39 (60.00%) |
| Warnings: | 5 (7.69%) |
| Errors: | 0 (0.00%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category Issue count by message number |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 28 | do ... while(0); |
| 2 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 39 | Variable 'hWnd' (line 27) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 3 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 27 | Location cited in prior message |
| 4 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 39 | Variable 'pButton' (line 30) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 5 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 30 | Location cited in prior message |
| 6 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 63 | Symbol 'COXBitmapButton' did not appear in the constructor initializer list -- Effective C++ #12 |
| 7 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 63 | Symbol 'COXColorPickerButton::m_nColorBandHeight' did not appear in the constructor initializer list -- Effective C++ #12 |
| 8 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 63 | Symbol 'COXColorPickerButton::m_clr' did not appear in the constructor initializer list -- Effective C++ #12 |
| 9 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 67 | parameter 'sizeButton' in function 'COXColorPickerButton::COXColorPickerButton(unsigned int, unsigned int, unsigned long, CSize, int, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
| 10 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 67 | Parameter 'sizeButton' (line 58) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 11 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 58 | Location cited in prior message |
| 12 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 106 | do ... while(0); |
| 13 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 111 | Variable 'pThreadState' (line 100) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 14 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 100 | Location cited in prior message |
| 15 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 111 | Pointer variable 'pThreadState' (line 100) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 16 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 100 | Location cited in prior message |
| 17 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 115 | do ... while(0); |
| 18 | Warning | 3 | 613 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 117 | Possible use of null pointer 'lpDrawItemStruct' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp: line 115] |
| 19 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 115 | Reference cited in prior message |
| 20 | Warning | 3 | 613 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 118 | Possible use of null pointer 'lpDrawItemStruct' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp: line 115] |
| 21 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 115 | Reference cited in prior message |
| 22 | Warning | 3 | 613 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 119 | Possible use of null pointer 'lpDrawItemStruct' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp: line 115] |
| 23 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 115 | Reference cited in prior message |
| 24 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 154 | Loss of sign in promotion from long to unsigned long |
| 25 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 154 | Loss of sign in promotion from long to unsigned long |
| 26 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 154 | Loss of precision (assignment) (unsigned long to long) |
| 27 | Information | 2 | 834 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 172 | Operator '-' followed by operator '+' is confusing. Use parentheses. |
| 28 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 173 | Loss of sign in promotion from long to unsigned long |
| 29 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 173 | Loss of precision (assignment) (unsigned long to long) |
| 30 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 189 | Ignoring return value of function 'CWnd::SetWindowPos(const CWnd *, int, int, int, int, unsigned int)' (compare with line 2265, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 31 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2265 | Location cited in prior message |
| 32 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 195 | Parameter 'lpDrawItemStruct' (line 113) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 33 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 113 | Location cited in prior message |
| 34 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 195 | Variable 'pDC' (line 117) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 35 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 117 | Location cited in prior message |
| 36 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 195 | Variable 'itemRect' (line 119) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 37 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 119 | Location cited in prior message |
| 38 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 220 | Variable 'clrShadow' (line 199) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 39 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 199 | Location cited in prior message |
| 40 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 220 | Parameter 'nState' (line 197) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 41 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 197 | Location cited in prior message |
| 42 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 220 | Parameter 'colorBandRect' (line 197) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 43 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 197 | Location cited in prior message |
| 44 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 224 | do ... while(0); |
| 45 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 225 | do ... while(0); |
| 46 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 227 | do ... while(0); |
| 47 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 245 | Loss of sign in promotion from long to unsigned long |
| 48 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 245 | Loss of sign in promotion from long to unsigned long |
| 49 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 245 | Loss of precision (assignment) (unsigned long to long) |
| 50 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 262 | Parameter 'clr' (line 251) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 51 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 251 | Location cited in prior message |
| 52 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 262 | Parameter 'bRedraw' (line 251) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 53 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 251 | Location cited in prior message |
| 54 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 278 | Ignoring return value of function 'CWnd::SendMessageA(unsigned int, unsigned int, long) const' (compare with line 2222, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 55 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2222 | Location cited in prior message |
| 56 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 280 | Variable 'clr' (line 271) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 57 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 271 | Location cited in prior message |
| 58 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 280 | Variable 'pParentWnd' (line 275) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 59 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 275 | Location cited in prior message |
| 60 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 280 | Pointer variable 'pParentWnd' (line 275) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 61 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 275 | Location cited in prior message |
| 62 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 283 | Parameter 'wParam' (line 265) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 63 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 265 | Location cited in prior message |
| 64 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 283 | Parameter 'lParam' (line 265) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 65 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp | 265 | Location cited in prior message |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp (C++)
#... k() ; } while (0) /*lint -restore */
ASSERT(hWnd!=NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(28): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(39): error 953: (Note -- Variable 'hWnd' (line 27) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(27): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(39): error 953: (Note -- Variable 'pButton' (line 30) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(30): error 830: (Info -- Location cited in prior message)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(63): error 1928: (Note -- Symbol 'COXBitmapButton' did not appear in the constructor initializer list -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(63): error 1927: (Note -- Symbol 'COXColorPickerButton::m_nColorBandHeight' did not appear in the constructor initializer list -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(63): error 1927: (Note -- Symbol 'COXColorPickerButton::m_clr' did not appear in the constructor initializer list -- Effective C++ #12)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(67): error 1746: (Info -- parameter 'sizeButton' in function 'COXColorPickerButton::COXColorPickerButton(unsigned int, unsigned int, unsigned long, CSize, int, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(67): error 952: (Note -- Parameter 'sizeButton' (line 58) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(58): error 830: (Info -- Location cited in prior message)
#... __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
#... 1551 */ASSERT(m_colorPicker.Create(this)) /*lint -restore */
VERIFY(m_colorPicker.Create(this));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(106): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(111): error 953: (Note -- Variable 'pThreadState' (line 100) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(100): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(111): error 954: (Note -- Pointer variable 'pThreadState' (line 100) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(100): error 830: (Info -- Location cited in prior message)
#... ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(lpDrawItemStruct != NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(115): error 717: (Info -- do ... while(0);)
CDC* pDC = CDC::FromHandle(lpDrawItemStruct->hDC);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(117): error 613: (Warning -- Possible use of null pointer 'lpDrawItemStruct' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp: line 115])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(115): error 831: (Info -- Reference cited in prior message)
UINT nState = lpDrawItemStruct->itemState;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(118): error 613: (Warning -- Possible use of null pointer 'lpDrawItemStruct' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp: line 115])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(115): error 831: (Info -- Reference cited in prior message)
CRect itemRect = lpDrawItemStruct->rcItem;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(119): error 613: (Warning -- Possible use of null pointer 'lpDrawItemStruct' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp: line 115])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(115): error 831: (Info -- Reference cited in prior message)
m_nColorBandHeight-m_ptColorBandOffset.y : 0;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(154): error 737: (Info -- Loss of sign in promotion from long to unsigned long)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(154): error 737: (Info -- Loss of sign in promotion from long to unsigned long)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(154): error 713: (Info -- Loss of precision (assignment) (unsigned long to long))
colorBandRect.top=rectFree.bottom+m_ptTextOffset.x-m_ptColorBandOffset.y+1;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(172): error 834: (Info -- Operator '-' followed by operator '+' is confusing. Use parentheses.)
colorBandRect.bottom=colorBandRect.top+m_nColorBandHeight;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(173): error 737: (Info -- Loss of sign in promotion from long to unsigned long)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(173): error 713: (Info -- Loss of precision (assignment) (unsigned long to long))
SWP_NOSIZE|SWP_NOZORDER);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(189): error 534: (Warning -- Ignoring return value of function 'CWnd::SetWindowPos(const CWnd *, int, int, int, int, unsigned int)' (compare with line 2265, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2265): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(195): error 952: (Note -- Parameter 'lpDrawItemStruct' (line 113) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(113): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(195): error 953: (Note -- Variable 'pDC' (line 117) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(117): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(195): error 953: (Note -- Variable 'itemRect' (line 119) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(119): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(220): error 953: (Note -- Variable 'clrShadow' (line 199) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(199): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(220): error 952: (Note -- Parameter 'nState' (line 197) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(197): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(220): error 952: (Note -- Parameter 'colorBandRect' (line 197) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(197): error 830: (Info -- Location cited in prior message)
#... ebugBreak() ; } while (0) /*lint -restore */
ASSERT(::IsWindow(m_hWnd));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(224): error 717: (Info -- do ... while(0);)
#... ebugBreak() ; } while (0) /*lint -restore */
ASSERT(IsDropDownButton());
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(225): error 717: (Info -- do ... while(0);)
#... LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(::IsWindow(m_colorPicker.m_hWnd));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(227): error 717: (Info -- do ... while(0);)
sizeReserved.cy+=m_nColorBandHeight-m_ptColorBandOffset.y;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(245): error 737: (Info -- Loss of sign in promotion from long to unsigned long)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(245): error 737: (Info -- Loss of sign in promotion from long to unsigned long)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(245): error 713: (Info -- Loss of precision (assignment) (unsigned long to long))
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(262): error 952: (Note -- Parameter 'clr' (line 251) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(251): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(262): error 952: (Note -- Parameter 'bRedraw' (line 251) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(251): error 830: (Info -- Location cited in prior message)
pParentWnd->SendMessage(OXPBN_SELCHANGED,0,(LPARAM)GetSafeHwnd());
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(278): error 534: (Warning -- Ignoring return value of function 'CWnd::SendMessageA(unsigned int, unsigned int, long) const' (compare with line 2222, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2222): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(280): error 953: (Note -- Variable 'clr' (line 271) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(271): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(280): error 953: (Note -- Variable 'pParentWnd' (line 275) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(275): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(280): error 954: (Note -- Pointer variable 'pParentWnd' (line 275) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(275): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(283): error 952: (Note -- Parameter 'wParam' (line 265) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(265): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(283): error 952: (Note -- Parameter 'lParam' (line 265) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXColorPickerButton.cpp(265): error 830: (Info -- Location cited in prior message)
--- Global Wrap-up
error 900: (Note -- Successful completion, 65 messages produced)