Issue count by category  Issue count by message number  |
Lint Analysis Results Report for OXCustomizePage.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Complete |
| Last Analysed: | 08 October 2008, 12:01:30 |
| Total Issues: | 31 |
| Elective Notes: | 6 (19.35%) |
| Informational: | 19 (61.29%) |
| Warnings: | 6 (19.35%) |
| Errors: | 0 (0.00%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category Issue count by message number |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Information | 2 | 1729 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 48 | Initializer inversion detected for member 'COXCustomizePage::m_pCustomizeManager' -- Effective C++ #13 |
| 2 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 51 | Symbol 'CWnd' did not appear in the constructor initializer list -- Effective C++ #12 |
| 3 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 51 | Symbol 'COXCustomizePage::m_LayoutManager's default constructor implicitly called -- Effective C++ #12 |
| 4 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 51 | Symbol 'COXCustomizePage::m_pOccDialogInfo' did not appear in the constructor initializer list -- Effective C++ #12 |
| 5 | Warning | 3 | 1540 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 59 | Pointer member 'COXCustomizePage::m_pCustomizeManager' (line 224, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXCustomizePage.h) neither freed nor zeroed by destructor -- Effective C++ #6 |
| 6 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXCustomizePage.h | 224 | Location cited in prior message |
| 7 | Warning | 3 | 1540 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 59 | Pointer member 'COXCustomizePage::m_pOccDialogInfo' (line 388, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXCustomizePage.h) neither freed nor zeroed by destructor -- Effective C++ #6 |
| 8 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXCustomizePage.h | 388 | Location cited in prior message |
| 9 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 76 | do ... while(0); |
| 10 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 77 | do ... while(0); |
| 11 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 80 | do ... while(0); |
| 12 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 87 | Loss of precision (assignment) (unsigned long to long) |
| 13 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 98 | Ignoring return value of function 'CWnd::ModifyStyle(unsigned long, unsigned long, unsigned int)' (compare with line 2105, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 14 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2105 | Location cited in prior message |
| 15 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 99 | Ignoring return value of function 'CWnd::ModifyStyleEx(unsigned long, unsigned long, unsigned int)' (compare with line 2106, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 16 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2106 | Location cited in prior message |
| 17 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 101 | Loss of precision (arg. no. 1) (unsigned int to int) |
| 18 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 101 | Ignoring return value of function 'CWnd::SetDlgCtrlID(int)' (compare with line 2194, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 19 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2194 | Location cited in prior message |
| 20 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 113 | Ignoring return value of function 'CWnd::SetWindowPos(const CWnd *, int, int, int, int, unsigned int)' (compare with line 2265, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 21 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2265 | Location cited in prior message |
| 22 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 120 | Parameter 'lpszTemplateName' (line 73) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 23 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 73 | Location cited in prior message |
| 24 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 120 | Variable 'bShowWindow' (line 82) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 25 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 82 | Location cited in prior message |
| 26 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 125 | do ... while(0); |
| 27 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 126 | do ... while(0); |
| 28 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 127 | do ... while(0); |
| 29 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 131 | do ... while(0); |
| 30 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 173 | do ... while(0); |
| 31 | Elective Note | 1 | 1961 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp | 210 | virtual member function 'COXCustomizePage::SaveWorkspaceState(void)' could be made const --- Eff. C++ 3rd Ed. item 3 |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp (C++)
m_pCustomizeManager(NULL),
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(48): error 1729: (Info -- Initializer inversion detected for member 'COXCustomizePage::m_pCustomizeManager' -- Effective C++ #13)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(51): error 1928: (Note -- Symbol 'CWnd' did not appear in the constructor initializer list -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(51): error 1926: (Note -- Symbol 'COXCustomizePage::m_LayoutManager's default constructor implicitly called -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(51): error 1927: (Note -- Symbol 'COXCustomizePage::m_pOccDialogInfo' did not appear in the constructor initializer list -- Effective C++ #12)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(59): error 1540: (Warning -- Pointer member 'COXCustomizePage::m_pCustomizeManager' (line 224, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXCustomizePage.h) neither freed nor zeroed by destructor -- Effective C++ #6)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXCustomizePage.h(224): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(59): error 1540: (Warning -- Pointer member 'COXCustomizePage::m_pOccDialogInfo' (line 388, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXCustomizePage.h) neither freed nor zeroed by destructor -- Effective C++ #6)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXCustomizePage.h(388): error 830: (Info -- Location cited in prior message)
#... ugBreak() ; } while (0) /*lint -restore */
ASSERT(pParentWnd!=NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(76): error 717: (Info -- do ... while(0);)
#... AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(lpszTemplateName!=NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(77): error 717: (Info -- do ... while(0);)
#... S_FILE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
#... e1551 */ASSERT(AfxEndDeferRegisterClass(0x00010)) /*lint -restore */
VERIFY(AfxDeferRegisterClass(AFX_WNDCOMMCTLS_REG));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(80): error 717: (Info -- do ... while(0);)
cs.style=dwStyle;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(87): error 713: (Info -- Loss of precision (assignment) (unsigned long to long))
ModifyStyle(WS_BORDER|WS_CAPTION,(cs.style&~(WS_BORDER|WS_CAPTION))|WS_CHILD);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(98): error 534: (Warning -- Ignoring return value of function 'CWnd::ModifyStyle(unsigned long, unsigned long, unsigned int)' (compare with line 2105, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2105): error 830: (Info -- Location cited in prior message)
ModifyStyleEx(WS_EX_CLIENTEDGE,(cs.dwExStyle&~WS_EX_CLIENTEDGE));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(99): error 534: (Warning -- Ignoring return value of function 'CWnd::ModifyStyleEx(unsigned long, unsigned long, unsigned int)' (compare with line 2106, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2106): error 830: (Info -- Location cited in prior message)
SetDlgCtrlID(nID);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(101): error 713: (Info -- Loss of precision (arg. no. 1) (unsigned int to int))
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(101): error 534: (Warning -- Ignoring return value of function 'CWnd::SetDlgCtrlID(int)' (compare with line 2194, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2194): error 830: (Info -- Location cited in prior message)
SWP_NOZORDER|SWP_NOACTIVATE);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(113): error 534: (Warning -- Ignoring return value of function 'CWnd::SetWindowPos(const CWnd *, int, int, int, int, unsigned int)' (compare with line 2265, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2265): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(120): error 952: (Note -- Parameter 'lpszTemplateName' (line 73) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(73): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(120): error 953: (Note -- Variable 'bShowWindow' (line 82) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(82): error 830: (Info -- Location cited in prior message)
#... AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(m_nDialogID!=0xffffffff);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(125): error 717: (Info -- do ... while(0);)
#... AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(pCustomizeManager!=NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(126): error 717: (Info -- do ... while(0);)
#... ) ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(m_pCustomizeManager==NULL || m_pCustomizeManager==pCustomizeManager);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(127): error 717: (Info -- do ... while(0);)
#... S_FILE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(m_pCustomizeManager==pCustomizeManager);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(131): error 717: (Info -- do ... while(0);)
#... k() ; } while (0) /*lint -restore */
ASSERT(pMsg!=NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(173): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCustomizePage.cpp(210): error 1961: (Note -- virtual member function 'COXCustomizePage::SaveWorkspaceState(void)' could be made const --- Eff. C++ 3rd Ed. item 3)
--- Global Wrap-up
error 900: (Note -- Successful completion, 31 messages produced)