Issue count by category  Issue count by message number  |
Lint Analysis Results Report for OXMetaFile.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Complete |
| Last Analysed: | 08 October 2008, 12:09:18 |
| Total Issues: | 112 |
| Elective Notes: | 28 (25.00%) |
| Informational: | 66 (58.93%) |
| Warnings: | 17 (15.18%) |
| Errors: | 1 (0.89%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category Issue count by message number |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 31 | Symbol 'COXMetaFile::m_rectBounds's default constructor implicitly called -- Effective C++ #12 |
| 2 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 31 | Symbol 'COXMetaFile::m_rectNormalized's default constructor implicitly called -- Effective C++ #12 |
| 3 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 31 | Symbol 'COXMetaFile::m_lpEnhMetaProc' did not appear in the constructor initializer list -- Effective C++ #12 |
| 4 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 31 | Symbol 'COXMetaFile::m_strFileName's default constructor implicitly called -- Effective C++ #12 |
| 5 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 31 | Symbol 'COXMetaFile::m_strDescription's default constructor implicitly called -- Effective C++ #12 |
| 6 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 31 | Symbol 'COXMetaFile::m_hEMF' did not appear in the constructor initializer list -- Effective C++ #12 |
| 7 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 31 | Symbol 'COXMetaFile::m_hDCMeta' did not appear in the constructor initializer list -- Effective C++ #12 |
| 8 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 31 | Symbol 'COXMetaFile::m_metafileType' did not appear in the constructor initializer list -- Effective C++ #12 |
| 9 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 43 | Ignoring return value of function 'DeleteEnhMetaFile(struct HENHMETAFILE__ *)' (compare with line 3902, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h) |
| 10 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h | 3902 | Location cited in prior message |
| 11 | Information | 2 | 1740 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 44 | pointer member 'COXMetaFile::m_hEMF' (line 389, file ..\..\Include\OXMetaFile.h) not directly freed or zeroed by destructor -- Effective C++ #6 |
| 12 | Information | 2 | 830 | ..\..\Include\OXMetaFile.h | 389 | Location cited in prior message |
| 13 | Information | 2 | 1740 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 44 | pointer member 'COXMetaFile::m_hDCMeta' (line 390, file ..\..\Include\OXMetaFile.h) not directly freed or zeroed by destructor -- Effective C++ #6 |
| 14 | Information | 2 | 830 | ..\..\Include\OXMetaFile.h | 390 | Location cited in prior message |
| 15 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 65 | Ignoring return value of function 'COXMetaFile::LoadFile(void *)' (compare with line 382, file ..\..\Include\OXMetaFile.h) |
| 16 | Information | 2 | 830 | ..\..\Include\OXMetaFile.h | 382 | Location cited in prior message |
| 17 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 66 | Ignoring return value of function 'UnlockResource(void *)' (compare with line 279, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxv_w32.h) |
| 18 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxv_w32.h | 279 | Location cited in prior message |
| 19 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 68 | parameter 'strResType' in function 'COXMetaFile::LoadFile(int, ATL::CStringT<char,StrTraitMFC_DLL<char>>)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
| 20 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 68 | Parameter 'strResType' (line 50) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 21 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 50 | Location cited in prior message |
| 22 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 68 | Variable 'hRsrc' (line 54) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 23 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 54 | Location cited in prior message |
| 24 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 101 | Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
| 25 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 4624 | Location cited in prior message |
| 26 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 110 | Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
| 27 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 4624 | Location cited in prior message |
| 28 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 111 | Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
| 29 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 4624 | Location cited in prior message |
| 30 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 116 | Ignoring return value of function 'UnmapViewOfFile(const void *)' (compare with line 5414, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
| 31 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 5414 | Location cited in prior message |
| 32 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 117 | Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
| 33 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 4624 | Location cited in prior message |
| 34 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 118 | Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
| 35 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 4624 | Location cited in prior message |
| 36 | Warning | 3 | 550 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 120 | Symbol 'bSuccess' (line 74) not accessed |
| 37 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 74 | Location cited in prior message |
| 38 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 120 | parameter 'strFileName' in function 'COXMetaFile::LoadFile(ATL::CStringT<char,StrTraitMFC_DLL<char>>)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
| 39 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 120 | Parameter 'strFileName' (line 70) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 40 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 70 | Location cited in prior message |
| 41 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 131 | Loss of sign (arg. no. 1) (int to unsigned int) |
| 42 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 131 | do ... while(0); |
| 43 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 152 | parameter 'sDefExt' in function 'COXMetaFile::CreateFileA(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
| 44 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 152 | Parameter 'sDefExt' (line 126) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 45 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 126 | Location cited in prior message |
| 46 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 152 | parameter 'strDescript' in function 'COXMetaFile::CreateFileA(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
| 47 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 152 | Parameter 'strDescript' (line 125) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 48 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 125 | Location cited in prior message |
| 49 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 152 | parameter 'strFileName' in function 'COXMetaFile::CreateFileA(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
| 50 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 152 | Parameter 'strFileName' (line 125) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 51 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 125 | Location cited in prior message |
| 52 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 159 | Ignoring return value of function 'DeleteEnhMetaFile(struct HENHMETAFILE__ *)' (compare with line 3902, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h) |
| 53 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h | 3902 | Location cited in prior message |
| 54 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 174 | Parameter 'pDC' (line 169) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 55 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 169 | Location cited in prior message |
| 56 | Information | 2 | 818 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 174 | Pointer parameter 'pDC' (line 169) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 57 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 169 | Location cited in prior message |
| 58 | Warning | 3 | 505 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 191 | Redundant left argument to comma |
| 59 | Warning | 3 | 505 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 191 | Redundant left argument to comma |
| 60 | Warning | 3 | 505 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 191 | Redundant left argument to comma |
| 61 | Error | 4 | 1037 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 191 | ambiguous reference to conversion function; candidates: CRect::operator tagRECT *(void) (line 155, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\atltypes.h) and CRect::operator const tagRECT *(void) const (line 156, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\atltypes.h)' |
| 62 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\atltypes.h | 155 | Location cited in prior message |
| 63 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\atltypes.h | 156 | Location cited in prior message |
| 64 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 191 | do ... while(0); |
| 65 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 204 | Parameter 'pClientRect' (line 176) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 66 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 176 | Location cited in prior message |
| 67 | Information | 2 | 818 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 204 | Pointer parameter 'pClientRect' (line 176) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 68 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 176 | Location cited in prior message |
| 69 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 204 | Variable 'nOldMapMode' (line 180) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 70 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 180 | Location cited in prior message |
| 71 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 212 | do ... while(0); |
| 72 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 214 | Parameter 'pDC' (line 207) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 73 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 207 | Location cited in prior message |
| 74 | Information | 2 | 818 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 214 | Pointer parameter 'pDC' (line 207) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 75 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 207 | Location cited in prior message |
| 76 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 214 | parameter 'crect' in function 'COXMetaFile::PlayRecords(CDC *, CRect, int (__stdcall *)(struct HDC__ *, struct tagHANDLETABLE *, const struct tagENHMETARECORD *, int, long), void *)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
| 77 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 214 | Parameter 'crect' (line 207) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 78 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 207 | Location cited in prior message |
| 79 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 214 | Parameter 'lpEnhMetaProc' (line 208) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 80 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 208 | Location cited in prior message |
| 81 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 228 | Ignoring return value of function 'DeleteEnhMetaFile(struct HENHMETAFILE__ *)' (compare with line 3902, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h) |
| 82 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h | 3902 | Location cited in prior message |
| 83 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 257 | Ignoring return value of function 'GetEnhMetaFileHeader(struct HENHMETAFILE__ *, unsigned int, struct tagENHMETAHEADER *)' (compare with line 3926, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h) |
| 84 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h | 3926 | Location cited in prior message |
| 85 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 268 | Loss of precision (arg. no. 1) (unsigned long to int) |
| 86 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 268 | Loss of precision (arg. no. 1) (unsigned long to int) |
| 87 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 268 | Ignoring return value of function 'GetEnhMetaFileDescriptionA(struct HENHMETAFILE__ *, unsigned int, char *)' (compare with line 3915, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h) |
| 88 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h | 3915 | Location cited in prior message |
| 89 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 288 | Suspicious pointer-to-pointer conversion (area too small) |
| 90 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 293 | do ... while(0); |
| 91 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 312 | Suspicious pointer-to-pointer conversion (area too small) |
| 92 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 314 | do ... while(0); |
| 93 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 327 | Pointer variable 'pAldusMF' (line 222) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 94 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 222 | Location cited in prior message |
| 95 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 327 | Variable 'hdcRef' (line 234) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 96 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 234 | Location cited in prior message |
| 97 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 327 | Variable 'pemh' (line 223) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 98 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 223 | Location cited in prior message |
| 99 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 327 | Pointer variable 'pemh' (line 223) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 100 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 223 | Location cited in prior message |
| 101 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 327 | Variable 'iWidthMM' (line 240) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 102 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 240 | Location cited in prior message |
| 103 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 327 | Variable 'iWidthPels' (line 242) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 104 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 242 | Location cited in prior message |
| 105 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 327 | Variable 'iHeightMM' (line 241) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 106 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 241 | Location cited in prior message |
| 107 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 327 | Variable 'iHeightPels' (line 243) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 108 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 243 | Location cited in prior message |
| 109 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 288 | Suspicious pointer-to-pointer conversion (area too small) |
| 110 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 312 | Suspicious pointer-to-pointer conversion (area too small) |
| 111 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 288 | Suspicious pointer-to-pointer conversion (area too small) |
| 112 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp | 312 | Suspicious pointer-to-pointer conversion (area too small) |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp (C++)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(31): error 1926: (Note -- Symbol 'COXMetaFile::m_rectBounds's default constructor implicitly called -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(31): error 1926: (Note -- Symbol 'COXMetaFile::m_rectNormalized's default constructor implicitly called -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(31): error 1927: (Note -- Symbol 'COXMetaFile::m_lpEnhMetaProc' did not appear in the constructor initializer list -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(31): error 1926: (Note -- Symbol 'COXMetaFile::m_strFileName's default constructor implicitly called -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(31): error 1926: (Note -- Symbol 'COXMetaFile::m_strDescription's default constructor implicitly called -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(31): error 1927: (Note -- Symbol 'COXMetaFile::m_hEMF' did not appear in the constructor initializer list -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(31): error 1927: (Note -- Symbol 'COXMetaFile::m_hDCMeta' did not appear in the constructor initializer list -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(31): error 1927: (Note -- Symbol 'COXMetaFile::m_metafileType' did not appear in the constructor initializer list -- Effective C++ #12)
DeleteEnhMetaFile(m_hEMF);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(43): error 534: (Warning -- Ignoring return value of function 'DeleteEnhMetaFile(struct HENHMETAFILE__ *)' (compare with line 3902, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h(3902): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(44): error 1740: (Info -- pointer member 'COXMetaFile::m_hEMF' (line 389, file ..\..\Include\OXMetaFile.h) not directly freed or zeroed by destructor -- Effective C++ #6)
..\..\Include\OXMetaFile.h(389): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(44): error 1740: (Info -- pointer member 'COXMetaFile::m_hDCMeta' (line 390, file ..\..\Include\OXMetaFile.h) not directly freed or zeroed by destructor -- Effective C++ #6)
..\..\Include\OXMetaFile.h(390): error 830: (Info -- Location cited in prior message)
LoadFile(lpvData);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(65): error 534: (Warning -- Ignoring return value of function 'COXMetaFile::LoadFile(void *)' (compare with line 382, file ..\..\Include\OXMetaFile.h))
..\..\Include\OXMetaFile.h(382): error 830: (Info -- Location cited in prior message)
UnlockResource(hResource) ;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(66): error 534: (Warning -- Ignoring return value of function 'UnlockResource(void *)' (compare with line 279, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxv_w32.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxv_w32.h(279): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(68): error 1746: (Info -- parameter 'strResType' in function 'COXMetaFile::LoadFile(int, ATL::CStringT<char,StrTraitMFC_DLL<char>>)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(68): error 952: (Note -- Parameter 'strResType' (line 50) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(50): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(68): error 953: (Note -- Variable 'hRsrc' (line 54) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(54): error 830: (Info -- Location cited in prior message)
CloseHandle(hFile);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(101): error 534: (Warning -- Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(4624): error 830: (Info -- Location cited in prior message)
CloseHandle(hMapFile);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(110): error 534: (Warning -- Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(4624): error 830: (Info -- Location cited in prior message)
CloseHandle(hFile);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(111): error 534: (Warning -- Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(4624): error 830: (Info -- Location cited in prior message)
UnmapViewOfFile(pMapFile);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(116): error 534: (Warning -- Ignoring return value of function 'UnmapViewOfFile(const void *)' (compare with line 5414, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(5414): error 830: (Info -- Location cited in prior message)
CloseHandle(hMapFile);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(117): error 534: (Warning -- Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(4624): error 830: (Info -- Location cited in prior message)
CloseHandle(hFile);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(118): error 534: (Warning -- Ignoring return value of function 'CloseHandle(void *)' (compare with line 4624, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(4624): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(120): error 550: (Warning -- Symbol 'bSuccess' (line 74) not accessed)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(74): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(120): error 1746: (Info -- parameter 'strFileName' in function 'COXMetaFile::LoadFile(ATL::CStringT<char,StrTraitMFC_DLL<char>>)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(120): error 952: (Note -- Parameter 'strFileName' (line 70) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(70): error 830: (Info -- Location cited in prior message)
#... f ( !(sFilter.LoadStringA(nIDFilter)) && AdvancedAssertFailedLine(_T("sFil
#... SERT(sFilter.LoadStringA(nIDFilter)) /*lint -restore */
VERIFY(sFilter.LoadString(nIDFilter));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(131): error 732: (Info -- Loss of sign (arg. no. 1) (int to unsigned int))
#... E__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
#... SERT(sFilter.LoadStringA(nIDFilter)) /*lint -restore */
VERIFY(sFilter.LoadString(nIDFilter));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(131): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(152): error 1746: (Info -- parameter 'sDefExt' in function 'COXMetaFile::CreateFileA(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(152): error 952: (Note -- Parameter 'sDefExt' (line 126) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(126): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(152): error 1746: (Info -- parameter 'strDescript' in function 'COXMetaFile::CreateFileA(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(152): error 952: (Note -- Parameter 'strDescript' (line 125) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(125): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(152): error 1746: (Info -- parameter 'strFileName' in function 'COXMetaFile::CreateFileA(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(152): error 952: (Note -- Parameter 'strFileName' (line 125) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(125): error 830: (Info -- Location cited in prior message)
DeleteEnhMetaFile(m_hEMF);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(159): error 534: (Warning -- Ignoring return value of function 'DeleteEnhMetaFile(struct HENHMETAFILE__ *)' (compare with line 3902, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h(3902): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(174): error 952: (Note -- Parameter 'pDC' (line 169) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(169): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(174): error 818: (Info -- Pointer parameter 'pDC' (line 169) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(169): error 830: (Info -- Location cited in prior message)
#... o { if ( !(rectBounds!=(0,0,0,0)) && AdvancedAssertFailedLine(_T("rectBoun
ASSERT(rectBounds!=(0,0,0,0));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(191): error 505: (Warning -- Redundant left argument to comma)
#... { if ( !(rectBounds!=(0,0,0,0)) && AdvancedAssertFailedLine(_T("rectBounds
ASSERT(rectBounds!=(0,0,0,0));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(191): error 505: (Warning -- Redundant left argument to comma)
#... if ( !(rectBounds!=(0,0,0,0)) && AdvancedAssertFailedLine(_T("rectBounds!=
ASSERT(rectBounds!=(0,0,0,0));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(191): error 505: (Warning -- Redundant left argument to comma)
#... f ( !(rectBounds!=(0,0,0,0)) && AdvancedAssertFailedLine(_T("rectBounds!=(
ASSERT(rectBounds!=(0,0,0,0));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(191): error 1037: (Error -- ambiguous reference to conversion function; candidates: CRect::operator tagRECT *(void) (line 155, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\atltypes.h) and CRect::operator const tagRECT *(void) const (line 156, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\atltypes.h)')
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\atltypes.h(155): error 830: (Info -- Location cited in prior message)
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\atltypes.h(156): error 830: (Info -- Location cited in prior message)
#... fxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(rectBounds!=(0,0,0,0));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(191): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(204): error 952: (Note -- Parameter 'pClientRect' (line 176) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(176): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(204): error 818: (Info -- Pointer parameter 'pClientRect' (line 176) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(176): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(204): error 953: (Note -- Variable 'nOldMapMode' (line 180) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(180): error 830: (Info -- Location cited in prior message)
#... gBreak() ; } while (0) /*lint -restore */
ASSERT(m_lpEnhMetaProc);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(212): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(214): error 952: (Note -- Parameter 'pDC' (line 207) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(207): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(214): error 818: (Info -- Pointer parameter 'pDC' (line 207) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(207): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(214): error 1746: (Info -- parameter 'crect' in function 'COXMetaFile::PlayRecords(CDC *, CRect, int (__stdcall *)(struct HDC__ *, struct tagHANDLETABLE *, const struct tagENHMETARECORD *, int, long), void *)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(214): error 952: (Note -- Parameter 'crect' (line 207) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(207): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(214): error 952: (Note -- Parameter 'lpEnhMetaProc' (line 208) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(208): error 830: (Info -- Location cited in prior message)
DeleteEnhMetaFile(m_hEMF);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(228): error 534: (Warning -- Ignoring return value of function 'DeleteEnhMetaFile(struct HENHMETAFILE__ *)' (compare with line 3902, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h(3902): error 830: (Info -- Location cited in prior message)
GetEnhMetaFileHeader(m_hEMF,sizeof(EnhMetaHeader),&EnhMetaHeader);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(257): error 534: (Warning -- Ignoring return value of function 'GetEnhMetaFileHeader(struct HENHMETAFILE__ *, unsigned int, struct tagENHMETAHEADER *)' (compare with line 3926, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h(3926): error 830: (Info -- Location cited in prior message)
m_strDescription.GetBufferSetLength(EnhMetaHeader.nDescription));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(268): error 713: (Info -- Loss of precision (arg. no. 1) (unsigned long to int))
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(268): error 713: (Info -- Loss of precision (arg. no. 1) (unsigned long to int))
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(268): error 534: (Warning -- Ignoring return value of function 'GetEnhMetaFileDescriptionA(struct HENHMETAFILE__ *, unsigned int, char *)' (compare with line 3915, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\wingdi.h(3915): error 830: (Info -- Location cited in prior message)
lSize = *((LPDWORD)((PBYTE)lpvData + APMSIZE + 6));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(288): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small))
#... 967)"), THIS_FILE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -resto
#... -e534 -e1551 */ASSERT(m_strDescription.LoadStringA(26967)) /*lint -resto
VERIFY(m_strDescription.LoadString(IDS_OX_METAFILEALDUS)); //"WMF - Aldus Format"
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(293): error 717: (Info -- do ... while(0);)
lSize = *((LPDWORD)((PBYTE)lpvData + 6));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(312): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small))
#... 8)"), THIS_FILE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore
#... -e534 -e1551 */ASSERT(m_strDescription.LoadStringA(26968)) /*lint -restore
VERIFY(m_strDescription.LoadString(IDS_OX_METAFILEWINDOWS)) ; //"Windows 3.x MetaFile"
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(314): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(327): error 954: (Note -- Pointer variable 'pAldusMF' (line 222) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(222): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(327): error 953: (Note -- Variable 'hdcRef' (line 234) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(234): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(327): error 953: (Note -- Variable 'pemh' (line 223) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(223): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(327): error 954: (Note -- Pointer variable 'pemh' (line 223) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(223): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(327): error 953: (Note -- Variable 'iWidthMM' (line 240) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(240): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(327): error 953: (Note -- Variable 'iWidthPels' (line 242) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(242): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(327): error 953: (Note -- Variable 'iHeightMM' (line 241) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(241): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(327): error 953: (Note -- Variable 'iHeightPels' (line 243) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(243): error 830: (Info -- Location cited in prior message)
During Specific Walk:
File D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp line 65: COXMetaFile::LoadFile(?)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(288): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small))
During Specific Walk:
File D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp line 65: COXMetaFile::LoadFile(?)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(312): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small))
During Specific Walk:
File D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp line 115: COXMetaFile::LoadFile(!=0)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(288): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small))
During Specific Walk:
File D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp line 115: COXMetaFile::LoadFile(!=0)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMetaFile.cpp(312): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small))
--- Global Wrap-up
error 900: (Note -- Successful completion, 112 messages produced)