Issue count by category  Issue count by message number  |
Lint Analysis Results Report for OXRegistryValFile.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Complete |
| Last Analysed: | 08 October 2008, 12:11:55 |
| Total Issues: | 24 |
| Elective Notes: | 6 (25.00%) |
| Informational: | 12 (50.00%) |
| Warnings: | 6 (25.00%) |
| Errors: | 0 (0.00%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category Issue count by message number |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 33 | Symbol 'COXRegistryValFile::m_value's default constructor implicitly called -- Effective C++ #12 |
| 2 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 38 | Symbol 'COXRegistryValFile::m_value's default constructor implicitly called -- Effective C++ #12 |
| 3 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 42 | Parameter 'lpszKey' (line 36) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 4 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 36 | Location cited in prior message |
| 5 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 42 | Parameter 'lpszValue' (line 36) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 6 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 36 | Location cited in prior message |
| 7 | Warning | 3 | 1506 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 47 | Call to virtual function 'COXRegistryValFile::Close(void)' within a constructor or destructor --- Eff. C++ 3rd Ed. item 9 |
| 8 | Warning | 3 | 1551 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 47 | Function may throw exception '...' in destructor 'COXRegistryValFile::~COXRegistryValFile(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8 |
| 9 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 55 | do ... while(0); |
| 10 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 56 | do ... while(0); |
| 11 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 101 | Parameter 'lpszKey' (line 53) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 12 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 53 | Location cited in prior message |
| 13 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 101 | Parameter 'lpszValue' (line 53) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 14 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 53 | Location cited in prior message |
| 15 | Warning | 3 | 429 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 101 | Custodial pointer 'pData' (line 74) has not been freed or returned |
| 16 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 74 | Location cited in prior message |
| 17 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 110 | Ignoring return value of function 'RegSetValueExA(struct HKEY__ *, const char *, unsigned long, unsigned long, const unsigned char *, unsigned long)' (compare with line 922, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h) |
| 18 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h | 922 | Location cited in prior message |
| 19 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 116 | do ... while(0); |
| 20 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 119 | Ignoring return value of function 'RegCloseKey(struct HKEY__ *)' (compare with line 180, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h) |
| 21 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h | 180 | Location cited in prior message |
| 22 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 131 | do ... while(0); |
| 23 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp | 133 | Ignoring return value of function 'RegCloseKey(struct HKEY__ *)' (compare with line 180, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h) |
| 24 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h | 180 | Location cited in prior message |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp (C++)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(33): error 1926: (Note -- Symbol 'COXRegistryValFile::m_value's default constructor implicitly called -- Effective C++ #12)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(38): error 1926: (Note -- Symbol 'COXRegistryValFile::m_value's default constructor implicitly called -- Effective C++ #12)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(42): error 952: (Note -- Parameter 'lpszKey' (line 36) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(36): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(42): error 952: (Note -- Parameter 'lpszValue' (line 36) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(36): error 830: (Info -- Location cited in prior message)
Close();
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(47): error 1506: (Warning -- Call to virtual function 'COXRegistryValFile::Close(void)' within a constructor or destructor --- Eff. C++ 3rd Ed. item 9)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(47): error 1551: (Warning -- Function may throw exception '...' in destructor 'COXRegistryValFile::~COXRegistryValFile(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8)
#... ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(AfxIsValidString(lpszKey));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(55): error 717: (Info -- do ... while(0);)
#... _) ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(AfxIsValidString(lpszValue));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(56): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(101): error 952: (Note -- Parameter 'lpszKey' (line 53) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(53): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(101): error 952: (Note -- Parameter 'lpszValue' (line 53) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(53): error 830: (Info -- Location cited in prior message)
During Specific Walk:
File D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp line 40: COXRegistryValFile::Open(?, ?, ?, ?)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(101): error 429: (Warning -- Custodial pointer 'pData' (line 74) has not been freed or returned)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(74): error 830: (Info -- Location cited in prior message)
::RegSetValueEx(m_key, m_value, 0, REG_BINARY, m_lpBuffer, (DWORD) GetLength());
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(110): error 534: (Warning -- Ignoring return value of function 'RegSetValueExA(struct HKEY__ *, const char *, unsigned long, unsigned long, const unsigned char *, unsigned long)' (compare with line 922, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h(922): error 830: (Info -- Location cited in prior message)
#... k() ; } while (0) /*lint -restore */
ASSERT(m_key != 0);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(116): error 717: (Info -- do ... while(0);)
::RegCloseKey(m_key);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(119): error 534: (Warning -- Ignoring return value of function 'RegCloseKey(struct HKEY__ *)' (compare with line 180, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h(180): error 830: (Info -- Location cited in prior message)
#... k() ; } while (0) /*lint -restore */
ASSERT(m_key != 0);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(131): error 717: (Info -- do ... while(0);)
::RegCloseKey(m_key);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXRegistryValFile.cpp(133): error 534: (Warning -- Ignoring return value of function 'RegCloseKey(struct HKEY__ *)' (compare with line 180, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winreg.h(180): error 830: (Info -- Location cited in prior message)
--- Global Wrap-up
error 900: (Note -- Successful completion, 24 messages produced)