Issue count by category  Issue count by message number  |
Lint Analysis Results Report for OXScreenGrab.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Underway |
| Last Analysed: | Unknown |
| Total Issues: | 35 |
| Elective Notes: | 4 (11.43%) |
| Informational: | 18 (51.43%) |
| Warnings: | 13 (37.14%) |
| Errors: | 0 (0.00%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category Issue count by message number |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 43 | Symbol 'CObject' did not appear in the constructor initializer list -- Effective C++ #12 |
| 2 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 43 | Symbol 'COXScreenGrabber::GrabDIB's default constructor implicitly called -- Effective C++ #12 |
| 3 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 78 | Ignoring return value of function 'DispatchMessageA(const struct tagMSG *)' (compare with line 3025, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winuser.h) |
| 4 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winuser.h | 3025 | Location cited in prior message |
| 5 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 87 | Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 6 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 566 | Location cited in prior message |
| 7 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 106 | Loss of sign in promotion from int to unsigned long |
| 8 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 106 | Loss of precision (assignment) (unsigned long to int) |
| 9 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 126 | Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 10 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 566 | Location cited in prior message |
| 11 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 127 | Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 12 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 566 | Location cited in prior message |
| 13 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 136 | Ignoring return value of function 'CDC::BitBlt(int, int, int, int, CDC *, int, int, unsigned long)' (compare with line 764, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 14 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 764 | Location cited in prior message |
| 15 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 139 | Ignoring return value of function 'CDC::SelectObject(CBitmap *)' (compare with line 589, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 16 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 589 | Location cited in prior message |
| 17 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 145 | Ignoring return value of function 'COXDIB::GetSystemPalette(CPalette *)' (compare with line 243, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\oxdib.h) |
| 18 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\oxdib.h | 243 | Location cited in prior message |
| 19 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 146 | Ignoring return value of function 'COXDIB::BitmapToDIB(struct HBITMAP__ *, CPalette *)' (compare with line 394, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\oxdib.h) |
| 20 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\oxdib.h | 394 | Location cited in prior message |
| 21 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 149 | Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 22 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 566 | Location cited in prior message |
| 23 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 150 | Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 24 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 566 | Location cited in prior message |
| 25 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 153 | Variable 'nYScrn' (line 93) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 26 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 93 | Location cited in prior message |
| 27 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 153 | Variable 'pOldBitmap' (line 133) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 28 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 133 | Location cited in prior message |
| 29 | Warning | 3 | 1536 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 157 | Exposing low access member 'COXScreenGrabber::GrabDIB' -- Effective C++ #30 |
| 30 | Information | 2 | 818 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 190 | Pointer parameter 'pWndFromStartPoint' (line 160) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 31 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 160 | Location cited in prior message |
| 32 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 212 | do ... while(0); |
| 33 | Warning | 3 | 613 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 213 | Possible use of null pointer 'pWnd' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp: line 212] |
| 34 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 212 | Reference cited in prior message |
| 35 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp | 229 | Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp (C++)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(43): error 1928: (Note -- Symbol 'CObject' did not appear in the constructor initializer list -- Effective C++ #12)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(43): error 1926: (Note -- Symbol 'COXScreenGrabber::GrabDIB's default constructor implicitly called -- Effective C++ #12)
DispatchMessage(&msg);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(78): error 534: (Warning -- Ignoring return value of function 'DispatchMessageA(const struct tagMSG *)' (compare with line 3025, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winuser.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winuser.h(3025): error 830: (Info -- Location cited in prior message)
SrcDC.DeleteDC();
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(87): error 534: (Warning -- Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(566): error 830: (Info -- Location cited in prior message)
nXScrn += devMode.dmPelsWidth;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(106): error 737: (Info -- Loss of sign in promotion from int to unsigned long)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(106): error 713: (Info -- Loss of precision (assignment) (unsigned long to int))
SrcDC.DeleteDC();
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(126): error 534: (Warning -- Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(566): error 830: (Info -- Location cited in prior message)
MemDC.DeleteDC();
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(127): error 534: (Warning -- Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(566): error 830: (Info -- Location cited in prior message)
MemDC.BitBlt(0, 0, SrcRect.Width(), SrcRect.Height(), &SrcDC, SrcRect.left, SrcRect.top, SRCCOPY);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(136): error 534: (Warning -- Ignoring return value of function 'CDC::BitBlt(int, int, int, int, CDC *, int, int, unsigned long)' (compare with line 764, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(764): error 830: (Info -- Location cited in prior message)
MemDC.SelectObject(pOldBitmap);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(139): error 534: (Warning -- Ignoring return value of function 'CDC::SelectObject(CBitmap *)' (compare with line 589, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(589): error 830: (Info -- Location cited in prior message)
COXDIB::GetSystemPalette(&SysPalette);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(145): error 534: (Warning -- Ignoring return value of function 'COXDIB::GetSystemPalette(CPalette *)' (compare with line 243, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\oxdib.h))
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\oxdib.h(243): error 830: (Info -- Location cited in prior message)
GrabDIB.BitmapToDIB(HBITMAP(ScreenBMP), &SysPalette);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(146): error 534: (Warning -- Ignoring return value of function 'COXDIB::BitmapToDIB(struct HBITMAP__ *, CPalette *)' (compare with line 394, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\oxdib.h))
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\oxdib.h(394): error 830: (Info -- Location cited in prior message)
SrcDC.DeleteDC();
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(149): error 534: (Warning -- Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(566): error 830: (Info -- Location cited in prior message)
MemDC.DeleteDC();
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(150): error 534: (Warning -- Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(566): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(153): error 953: (Note -- Variable 'nYScrn' (line 93) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(93): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(153): error 953: (Note -- Variable 'pOldBitmap' (line 133) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(133): error 830: (Info -- Location cited in prior message)
return &GrabDIB;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(157): error 1536: (Warning -- Exposing low access member 'COXScreenGrabber::GrabDIB' -- Effective C++ #30)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(190): error 818: (Info -- Pointer parameter 'pWndFromStartPoint' (line 160) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(160): error 830: (Info -- Location cited in prior message)
#... eak() ; } while (0) /*lint -restore */
ASSERT(pWnd != NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(212): error 717: (Info -- do ... while(0);)
if (!pWnd->IsWindowVisible())
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(213): error 613: (Warning -- Possible use of null pointer 'pWnd' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp: line 212])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(212): error 831: (Info -- Reference cited in prior message)
SreenDC.DeleteDC();
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXScreenGrab.cpp(229): error 534: (Warning -- Ignoring return value of function 'CDC::DeleteDC(void)' (compare with line 566, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))