Issue count by category  Issue count by message number  |
Lint Analysis Results Report for OXUxTheme.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Complete |
| Last Analysed: | 08 October 2008, 12:21:30 |
| Total Issues: | 36 |
| Elective Notes: | 9 (25.00%) |
| Informational: | 21 (58.33%) |
| Warnings: | 6 (16.67%) |
| Errors: | 0 (0.00%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category Issue count by message number |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 31 | Symbol 'COXUxTheme::m_hThemeDLL' did not appear in the constructor initializer list -- Effective C++ #12 |
| 2 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 38 | Ignoring return value of function 'FreeLibrary(struct HINSTANCE__ *)' (compare with line 2583, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
| 3 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 2583 | Location cited in prior message |
| 4 | Information | 2 | 1740 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 39 | pointer member 'COXUxTheme::m_hThemeDLL' (line 60, file ..\..\Include\OXUxTheme.h) not directly freed or zeroed by destructor -- Effective C++ #6 |
| 5 | Information | 2 | 830 | ..\..\Include\OXUxTheme.h | 60 | Location cited in prior message |
| 6 | Information | 2 | 1762 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 47 | Member function 'COXUxTheme::IsUxThemeLoaded(void)' could be made const --- Eff. C++ 3rd Ed. item 3 |
| 7 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 54 | do ... while(0); |
| 8 | Warning | 3 | 413 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 58 | Likely use of null pointer 'pfnGetWindowTheme' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 56] |
| 9 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 56 | Reference cited in prior message |
| 10 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 60 | Variable 'hTheme' (line 58) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 11 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 58 | Location cited in prior message |
| 12 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 64 | do ... while(0); |
| 13 | Warning | 3 | 413 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 68 | Likely use of null pointer 'pfnDrawThemeBackground' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 66] |
| 14 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 66 | Reference cited in prior message |
| 15 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 74 | Parameter 'pClipRect' (line 62) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 16 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 62 | Location cited in prior message |
| 17 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 74 | Parameter 'pRect' (line 62) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 18 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 62 | Location cited in prior message |
| 19 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 74 | Variable 'hr' (line 68) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 20 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 68 | Location cited in prior message |
| 21 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 79 | do ... while(0); |
| 22 | Warning | 3 | 413 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 83 | Likely use of null pointer 'pfnDrawThemeText' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 81] |
| 23 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 81 | Reference cited in prior message |
| 24 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 89 | Parameter 'lpszText' (line 76) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 25 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 76 | Location cited in prior message |
| 26 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 89 | Parameter 'pRect' (line 76) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 27 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 76 | Location cited in prior message |
| 28 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 89 | Variable 'hr' (line 83) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 29 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 83 | Location cited in prior message |
| 30 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 93 | do ... while(0); |
| 31 | Warning | 3 | 413 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 97 | Likely use of null pointer 'pfnGetThemeSysColor' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 95] |
| 32 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 95 | Reference cited in prior message |
| 33 | Warning | 3 | 413 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 107 | Likely use of null pointer 'pfnOpenThemeData' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 105] |
| 34 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 105 | Reference cited in prior message |
| 35 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 108 | Parameter 'lpszClassList' (line 100) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 36 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp | 100 | Location cited in prior message |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp (C++)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(31): error 1927: (Note -- Symbol 'COXUxTheme::m_hThemeDLL' did not appear in the constructor initializer list -- Effective C++ #12)
::FreeLibrary(m_hThemeDLL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(38): error 534: (Warning -- Ignoring return value of function 'FreeLibrary(struct HINSTANCE__ *)' (compare with line 2583, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h))
C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(2583): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(39): error 1740: (Info -- pointer member 'COXUxTheme::m_hThemeDLL' (line 60, file ..\..\Include\OXUxTheme.h) not directly freed or zeroed by destructor -- Effective C++ #6)
..\..\Include\OXUxTheme.h(60): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(47): error 1762: (Info -- Member function 'COXUxTheme::IsUxThemeLoaded(void)' could be made const --- Eff. C++ 3rd Ed. item 3)
#... DebugBreak() ; } while (0) /*lint -restore */
ASSERT(m_hThemeDLL != NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(54): error 717: (Info -- do ... while(0);)
HTHEME hTheme = (*pfnGetWindowTheme)(hWnd);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(58): error 413: (Warning -- Likely use of null pointer 'pfnGetWindowTheme' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 56])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(56): error 831: (Info -- Reference cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(60): error 953: (Note -- Variable 'hTheme' (line 58) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(58): error 830: (Info -- Location cited in prior message)
#... DebugBreak() ; } while (0) /*lint -restore */
ASSERT(m_hThemeDLL != NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(64): error 717: (Info -- do ... while(0);)
HRESULT hr = (*pfnDrawThemeBackground)(hTheme, hdc, iPartId, iStateId, pRect, pClipRect);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(68): error 413: (Warning -- Likely use of null pointer 'pfnDrawThemeBackground' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 66])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(66): error 831: (Info -- Reference cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(74): error 952: (Note -- Parameter 'pClipRect' (line 62) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(62): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(74): error 952: (Note -- Parameter 'pRect' (line 62) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(62): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(74): error 953: (Note -- Variable 'hr' (line 68) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(68): error 830: (Info -- Location cited in prior message)
#... DebugBreak() ; } while (0) /*lint -restore */
ASSERT(m_hThemeDLL != NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(79): error 717: (Info -- do ... while(0);)
HRESULT hr = (*pfnDrawThemeText)(hTheme, hdc, iPartId, iStateId, _bstr_t(lpszText), iCharCount, dwTextFlags, dwTextFlags2, pRect);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(83): error 413: (Warning -- Likely use of null pointer 'pfnDrawThemeText' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 81])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(81): error 831: (Info -- Reference cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(89): error 952: (Note -- Parameter 'lpszText' (line 76) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(76): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(89): error 952: (Note -- Parameter 'pRect' (line 76) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(76): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(89): error 953: (Note -- Variable 'hr' (line 83) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(83): error 830: (Info -- Location cited in prior message)
#... DebugBreak() ; } while (0) /*lint -restore */
ASSERT(m_hThemeDLL != NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(93): error 717: (Info -- do ... while(0);)
return (*pfnGetThemeSysColor)(hTheme, iColorID);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(97): error 413: (Warning -- Likely use of null pointer 'pfnGetThemeSysColor' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 95])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(95): error 831: (Info -- Reference cited in prior message)
return (*pfnOpenThemeData)(hWnd, _bstr_t(lpszClassList));
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(107): error 413: (Warning -- Likely use of null pointer 'pfnOpenThemeData' in argument to operator 'unary *' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp: line 105])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(105): error 831: (Info -- Reference cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(108): error 952: (Note -- Parameter 'lpszClassList' (line 100) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUxTheme.cpp(100): error 830: (Info -- Location cited in prior message)
--- Global Wrap-up
error 900: (Note -- Successful completion, 36 messages produced)